hsiang-c commented on code in PR #4752:
URL: https://github.com/apache/datafusion-comet/pull/4752#discussion_r3556056665
##########
dev/diffs/iceberg/1.11.0.diff:
##########
@@ -1,5 +1,5 @@
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
-index db659dc06b..78f5e3440f 100644
+index db659dc..78f5e34 100644
Review Comment:
Nit, we need to use 10 digits hash
##########
dev/diffs/iceberg/1.11.0.diff:
##########
@@ -57,8 +57,22 @@ index f766fbb79a..c5e31185a9 100644
.config(TestBase.DISABLE_UI)
.enableHiveSupport()
.getOrCreate();
+diff --git
a/spark/v4.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java
b/spark/v4.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java
+index b5d6415..0763a72 100644
+---
a/spark/v4.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java
++++
b/spark/v4.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java
+@@ -448,7 +448,8 @@ public abstract class SparkRowLevelOperationsTestBase
extends ExtensionsTestBase
+
+ protected void assertAllBatchScansVectorized(SparkPlan plan) {
+ List<SparkPlan> batchScans = SparkPlanUtil.collectBatchScans(plan);
+-
assertThat(batchScans).hasSizeGreaterThan(0).allMatch(SparkPlan::supportsColumnar);
++ // When Comet is enabled, its native scan replaces BatchScanExec nodes
entirely
++ assertThat(batchScans).allMatch(SparkPlan::supportsColumnar);
Review Comment:
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
