ozankabak commented on code in PR #11875:
URL: https://github.com/apache/datafusion/pull/11875#discussion_r1709162446
##########
datafusion/core/src/physical_optimizer/sort_pushdown.rs:
##########
@@ -132,6 +172,41 @@ fn pushdown_requirement_to_children(
RequirementsCompatibility::Compatible(adjusted) =>
Ok(Some(vec![adjusted])),
RequirementsCompatibility::NonCompatible => Ok(None),
}
+ } else if let Some(sort_exec) = plan.as_any().downcast_ref::<SortExec>() {
+ let sort_req = PhysicalSortRequirement::from_sort_exprs(
+ sort_exec.properties().output_ordering().unwrap_or(&[]),
+ );
+ if sort_exec
+ .properties()
+ .eq_properties
+ .requirements_compatible(parent_required, &sort_req)
+ {
+ debug_assert!(!parent_required.is_empty());
+ Ok(Some(vec![Some(parent_required.to_vec())]))
+ } else {
+ Ok(None)
+ }
+ } else if plan.fetch().is_some()
+ && plan.maintains_input_order().len() == 1
+ && plan.maintains_input_order()[0]
Review Comment:
I think this generalizes as "maintains input ordering of all children".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
