manuzhang opened a new pull request, #4878: URL: https://github.com/apache/datafusion-comet/pull/4878
## Which issue does this PR close? Closes #4836. ## Rationale for this change Comet can already serialize ROWS and RANGE window frame units, but GROUPS was not represented in the proto or mapped by the native planner. DataFusion supports GROUPS frames, so Comet can pass that frame unit through instead of rejecting it. ## What changes are included in this PR? - Add `Groups` to the window frame proto enum. - Serialize GROUPS frame units from Spark window frames when the frame type SQL spelling is `GROUPS`. - Convert GROUPS frames to DataFusion `WindowFrameUnits::Groups` and use unsigned physical offsets like ROWS frames. - Add focused native tests for GROUPS frame offsets and default unbounded bounds. ## How are these changes tested? - `cargo test -p datafusion-comet test_groups_window_frame --lib` - `./mvnw -Pjdk17 -DskipTests compile` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
