lyne7-sc commented on code in PR #23275:
URL: https://github.com/apache/datafusion/pull/23275#discussion_r3555986255
##########
datafusion/functions-aggregate/src/variance.rs:
##########
@@ -679,4 +717,89 @@ mod tests {
assert_eq!(result.value(0), 1.0);
Ok(())
}
+
+ #[test]
+ fn convert_to_state_roundtrips_through_merge() -> Result<()> {
Review Comment:
Thanks @kosiew, I added SLT coverage in `aggregate_skip_partial.slt` for the
skip-partial sql path. The new cases cover `variance/stddev`, `corr`, and
`count distinct` with nullable inputs and `FILTER`.
I also compared the same queries against the non-skip path locally and
confirmed the results match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
