zhuqi-lucas commented on code in PR #23332:
URL: https://github.com/apache/datafusion/pull/23332#discussion_r3557225969
##########
datafusion/physical-plan/src/execution_plan.rs:
##########
@@ -235,6 +235,27 @@ pub trait ExecutionPlan: Any + Debug + DisplayAs + Send +
Sync {
children: Vec<Arc<dyn ExecutionPlan>>,
) -> Result<Arc<dyn ExecutionPlan>>;
+ /// Fast-path used by [`with_new_children_if_necessary`] when the new
Review Comment:
Thanks @alamb for review, good point — filed as follow-up in #23441
(canonical `replace_children` + deprecate both existing methods + migrate ~30
impls). Prefer to keep this PR focused on the semantic change so the API rename
gets its own review thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
