gstvg commented on PR #22853: URL: https://github.com/apache/datafusion/pull/22853#issuecomment-4936570288
> For me it sounds like if you use `new` you can have the bug, and if you use `new_with_used_params` you wont have the bug. > > In that case, `new` should never be used, and if `new` should never be used there is no need for that function. > > however, adding argument that require you to traverse the expression without exposing (and documenting) a helper will make it very hard to use and source of bugs That makes sense @rluvaton, this design was my suggestion to @Adam-Alani, I focused too much on avoiding breaking changes to backport the fix, but that can be addressed in another issue/pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
