comphead commented on PR #4891: URL: https://github.com/apache/datafusion-comet/pull/4891#issuecomment-4947821021
> The extended explain plan just shows operators, but what if we include expressions and use a symbol to annotate whether the expression is rust or jvm? Maybe lets have at least possibility to recognize fallback codegen using this tool and we can improve it in follow up PR? Spark uses `!` to identify the operator has problems, we can use some other symbol yes > Why make this configurable? Don't we always want this? Did it configurable so it won't bleed to golden files, WDYT would be better? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
