jackylee-ch opened a new pull request, #23664: URL: https://github.com/apache/datafusion/pull/23664
## Which issue does this PR close? N/A ## Rationale for this change In the test helper `session_config_from_writer_props`, `data_pagesize_limit` is extracted from `props.dictionary_page_size_limit()` instead of `props.data_page_size_limit()`. The bug is masked because `parquet_options_with_non_defaults` sets both limits to the same value (42), so the roundtrip test cannot catch a mixed-up mapping between these two options. ## What changes are included in this PR? - Extract `data_pagesize_limit` from `props.data_page_size_limit()`. - Use distinct values for `data_pagesize_limit` (42) and `dictionary_page_size_limit` (43) in the test options so the roundtrip test can detect such mix-ups. ## Are these changes tested? Yes, covered by the existing `table_parquet_opts_to_writer_props` roundtrip test. Verified that reverting the extraction fix now makes the test fail. ## Are there any user-facing changes? No, test-only change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
