andygrove commented on PR #4927: URL: https://github.com/apache/datafusion-comet/pull/4927#issuecomment-5004401953
Thanks for the careful read @mbutrovich. Addressed in 2a3c5b56e: - Rewrote the PR description so it matches the actual diff: no criterion bench in-tree (tracked as a follow-up), no column-wide escape scan, and I called out what the change actually does (pre-rendered prefixes, style classification, direct `StringBuilder` writes, right-sized buffer). - Fixed the `Utf8View` pre-existing hole: string-view fields now go through the `Quoted` branch and are emitted as quoted, escaped JSON strings. - Sized `data_capacity` from `value_offsets` first/last instead of `value_data().len()` so sliced inputs no longer over-allocate. - Added five unit tests covering the branches you called out: float `NaN`/`Infinity`, string escaping, non-ASCII passthrough, `ignore_null_fields=false`, and `Utf8View` fields. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
