comphead commented on PR #4852: URL: https://github.com/apache/datafusion-comet/pull/4852#issuecomment-5004712568
> @comphead Bumping this — the previous reply covered why a function-based path is complementary to the classpath / plugin-jar inspection you outlined. If you would rather I add a `SparkSessionExtensions`-registered constant (e.g. `spark.sql.function.comet_version = `) instead of or in addition to the SQL function, happy to do that. Thanks @andygrove the function is also great, however it would bring up insignificant maintenance burden. If we follow spark then registered constant would be more expected way. Actually I'm fine either ways, leaving the final decision to you. The only thing is whatever way, we prob should describe it in User Guide or `plugin_overview.md` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
