github-actions[bot] commented on PR #23496: URL: https://github.com/apache/datafusion/pull/23496#issuecomment-5005357731
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-datasource v54.0.0 (current) Built [ 43.060s] (current) Parsing datafusion-datasource v54.0.0 (current) Parsed [ 0.033s] (current) Building datafusion-datasource v54.0.0 (baseline) Built [ 38.889s] (baseline) Parsing datafusion-datasource v54.0.0 (baseline) Parsed [ 0.032s] (baseline) Checking datafusion-datasource v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.256s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 83.698s] datafusion-datasource Building datafusion-datasource-arrow v54.0.0 (current) Built [ 43.979s] (current) Parsing datafusion-datasource-arrow v54.0.0 (current) Parsed [ 0.012s] (current) Building datafusion-datasource-arrow v54.0.0 (baseline) Built [ 38.404s] (baseline) Parsing datafusion-datasource-arrow v54.0.0 (baseline) Parsed [ 0.011s] (baseline) Checking datafusion-datasource-arrow v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.079s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 83.462s] datafusion-datasource-arrow Building datafusion-datasource-avro v54.0.0 (current) Built [ 41.895s] (current) Parsing datafusion-datasource-avro v54.0.0 (current) Parsed [ 0.010s] (current) Building datafusion-datasource-avro v54.0.0 (baseline) Built [ 38.473s] (baseline) Parsing datafusion-datasource-avro v54.0.0 (baseline) Parsed [ 0.010s] (baseline) Checking datafusion-datasource-avro v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.073s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 81.508s] datafusion-datasource-avro Building datafusion-datasource-csv v54.0.0 (current) Built [ 41.056s] (current) Parsing datafusion-datasource-csv v54.0.0 (current) Parsed [ 0.011s] (current) Building datafusion-datasource-csv v54.0.0 (baseline) Built [ 37.834s] (baseline) Parsing datafusion-datasource-csv v54.0.0 (baseline) Parsed [ 0.012s] (baseline) Checking datafusion-datasource-csv v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.105s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 79.941s] datafusion-datasource-csv Building datafusion-datasource-json v54.0.0 (current) Built [ 41.077s] (current) Parsing datafusion-datasource-json v54.0.0 (current) Parsed [ 0.012s] (current) Building datafusion-datasource-json v54.0.0 (baseline) Built [ 37.182s] (baseline) Parsing datafusion-datasource-json v54.0.0 (baseline) Parsed [ 0.013s] (baseline) Checking datafusion-datasource-json v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.099s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 79.325s] datafusion-datasource-json Building datafusion-datasource-parquet v54.0.0 (current) Built [ 46.805s] (current) Parsing datafusion-datasource-parquet v54.0.0 (current) Parsed [ 0.030s] (current) Building datafusion-datasource-parquet v54.0.0 (baseline) Built [ 42.284s] (baseline) Parsing datafusion-datasource-parquet v54.0.0 (baseline) Parsed [ 0.031s] (baseline) Checking datafusion-datasource-parquet v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.165s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 90.404s] datafusion-datasource-parquet Building datafusion-physical-plan v54.0.0 (current) Built [ 35.695s] (current) Parsing datafusion-physical-plan v54.0.0 (current) Parsed [ 0.139s] (current) Building datafusion-physical-plan v54.0.0 (baseline) Built [ 35.856s] (baseline) Parsing datafusion-physical-plan v54.0.0 (baseline) Parsed [ 0.140s] (baseline) Checking datafusion-physical-plan v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.712s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure trait_method_added: pub trait method added --- Description: A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_method_added.ron Failed in: trait method datafusion_physical_plan::proto::ExecutionPlanDecode::decode_plan_with_scalar_subquery_results in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/proto.rs:116 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 73.597s] datafusion-physical-plan Building datafusion-proto v54.0.0 (current) Built [ 58.487s] (current) Parsing datafusion-proto v54.0.0 (current) Parsed [ 0.018s] (current) Building datafusion-proto v54.0.0 (baseline) Built [ 59.320s] (baseline) Parsing datafusion-proto v54.0.0 (baseline) Parsed [ 0.020s] (baseline) Checking datafusion-proto v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.262s] 223 checks: 221 pass, 2 fail, 0 warn, 30 skip --- failure trait_method_marked_deprecated: trait method #[deprecated] added --- Description: A trait method is now #[deprecated]. Downstream crates will get a compiler warning when using this method. ref: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_method_marked_deprecated.ron Failed in: method try_into_explain_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_filter_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_csv_scan_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_json_scan_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_arrow_scan_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_parquet_scan_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_avro_scan_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_memory_scan_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_coalesce_batches_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_merge_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_repartition_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_global_limit_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_local_limit_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_window_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_aggregate_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_hash_join_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_symmetric_hash_join_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_union_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_interleave_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_cross_join_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_empty_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_placeholder_row_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_sort_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_sort_preserving_merge_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_nested_loop_join_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_analyze_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_unnest_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_sort_join in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_cooperative_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_async_func_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_buffer_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_into_scalar_subquery_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_explain_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_analyze_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_filter_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_global_limit_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_local_limit_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_hash_join_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_symmetric_hash_join_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_sort_merge_join_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_cross_join_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_aggregate_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_empty_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_placeholder_row_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_coalesce_batches_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_coalesce_partitions_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_repartition_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_sort_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_union_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_interleave_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_sort_preserving_merge_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_nested_loop_join_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_window_agg_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_bounded_window_agg_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_unnest_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_cooperative_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_async_func_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_buffer_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 method try_from_scalar_subquery_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:713 --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_method_missing.ron Failed in: method try_into_json_sink_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/60ca49fd5eb155b3d67dd28dddcfcec0441bfc35/datafusion/proto/src/physical_plan/mod.rs:2448 method try_into_csv_sink_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/60ca49fd5eb155b3d67dd28dddcfcec0441bfc35/datafusion/proto/src/physical_plan/mod.rs:2485 method try_into_parquet_sink_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/60ca49fd5eb155b3d67dd28dddcfcec0441bfc35/datafusion/proto/src/physical_plan/mod.rs:2523 method try_from_data_source_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/60ca49fd5eb155b3d67dd28dddcfcec0441bfc35/datafusion/proto/src/physical_plan/mod.rs:3525 method try_from_data_sink_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/60ca49fd5eb155b3d67dd28dddcfcec0441bfc35/datafusion/proto/src/physical_plan/mod.rs:4019 Summary semver requires new major version: 1 major and 1 minor checks failed Finished [ 119.182s] datafusion-proto ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
