adriangb commented on issue #21207: URL: https://github.com/apache/datafusion/issues/21207#issuecomment-5005737494
I think there's certainly a lot of room to improve the shape of the expressions. I agree there is not strong evidence for the current expressions, and we should not be married to `CASE` expressions. As an example, for hash joins thoughts I've had but have not been able to pursue: 1. We have a single filter for all partitions (combined ranges and/or join membership, might cost more upfront to build a single large hashmap). 2. Split out the range filters (always cheap to evaluate) from the membership filters, resulting in 2 different dynamic filters. 3. Have a `global OR per_partition` filter structure. 4. Use `OR` instead of `CASE`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
