asolimando commented on code in PR #23651: URL: https://github.com/apache/datafusion/pull/23651#discussion_r3605430617
########## datafusion/sqllogictest/test_files/statistics_registry.slt: ########## @@ -87,11 +88,8 @@ CREATE EXTERNAL TABLE dim_small STORED AS PARQUET LOCATION 'test_files/scratch/statistics_registry/dim_small.parquet'; -# -- Without registry -------------------------------------------------------- Review Comment: Having removed `use_statistics_registry` config knob means the registry can't be turned off within an SLT. The no-provider path is covered by existing tests indirectly, and the with/without contrast now lives in the `join_reorder` example -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
