asolimando commented on PR #23651: URL: https://github.com/apache/datafusion/pull/23651#issuecomment-5006798657
As discussed in https://github.com/apache/datafusion/pull/21122#issuecomment-4726842675, making `StatisticsRegistry` part of the default path was suggested by @alamb, who also [suggested](https://github.com/apache/datafusion/pull/21122#pullrequestreview-4247255961) to showcase it via an example, which I have added, showing a better plan (join build/probe flip) over built-in defaults, via a statistics provider. cc: - @kosiew as the original reviewer of https://github.com/apache/datafusion/pull/21483 - @xudong963 who gently reviewed many related contributions (notably https://github.com/apache/datafusion/pull/23051) - @alamb as the original idea behind this PR is yours, it would be great if you could confirm this matches what you meant Note: the diff reads large (+1055 / -332), but ~620 of the added lines are examples and tests, ~38 are docs. The core change is ~400 lines, which goes down to a more reasonable ~300 if you exclude mechanical fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
