blinding-pixels commented on PR #23627: URL: https://github.com/apache/datafusion/pull/23627#issuecomment-5006820623
Apologies, my bad on the length. Here is the short version- I agree on the assertion, split it by expected outcome so a Hash row can't pass with a RoundRobin. Reuse asserts zero `RepartitionExec`, Hash asserts exactly one and that it's Hash. On the trim, mutations say 4/5/6 are safe but 7, 13, and 14 are each the only test catching a specific branch. A reason I hesitated on the trim is that the neutral matrix enables the Range opt-in itself, so it stays green no matter what a production operator does. Only the SLTs catch that. Happy to push that and paste the mutation detail if you want it. The previous comment wasn't auto-generated but I did let an LLM write it up and didn't cut it down before posting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
