andygrove commented on PR #2090: URL: https://github.com/apache/datafusion-ballista/pull/2090#issuecomment-5015987852
> Only nit: adding an OOM warning to the config docs for the 0 + unbounded-pool combo. Other than that, LGTM. Test coverage looks good. Added. Thanks. > One question about having 2 spill triggers: In a world we mostly cover and account the bytes into memory pool, this local operator count and trigger wouldnt be necessary, right? Yes, if we had accurate memory accounting (perhaps backed by the real memory allocator - see https://github.com/apache/datafusion-ballista/pull/2033) I think we would revisit these configs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
