gene-bordegaray commented on code in PR #23520:
URL: https://github.com/apache/datafusion/pull/23520#discussion_r3615482123
##########
datafusion/ffi/src/physical_expr/partitioning.rs:
##########
@@ -99,5 +185,50 @@ mod tests {
assert_eq!(partitioning, returned);
}
}
+
+ Ok(())
+ }
+
+ #[test]
+ fn round_trip_ffi_range_partitioning_compound_key() -> Result<()> {
+ let a = Arc::new(Column::new("a", 0)) as Arc<dyn PhysicalExpr>;
Review Comment:
nit: could we use the helper function `range_partitioning()` to reduce
boiler plate in the tests here. Just changing the partitioning that is built in
there to compound 🤔
##########
datafusion/ffi/src/plan_properties.rs:
##########
@@ -282,6 +283,29 @@ mod tests {
))
}
+ fn create_range_test_props() -> Result<PlanProperties> {
+ use arrow::datatypes::{DataType, Field, Schema};
+ use datafusion_common::{ScalarValue, SplitPoint};
+ use datafusion_physical_expr::{LexOrdering, RangePartitioning};
+
Review Comment:
mega nit: I prfer to keep imports at the module level to keep tests clean
@timsaucer do yo uhave any preference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
