rluvaton commented on code in PR #23807:
URL: https://github.com/apache/datafusion/pull/23807#discussion_r3632197857
##########
datafusion/physical-expr/src/expressions/cast.rs:
##########
@@ -214,8 +214,18 @@ pub(crate) fn cast_expr_properties(
target_type: &DataType,
) -> Result<ExprProperties> {
let unbounded = Interval::make_unbounded(target_type)?;
- if is_order_preserving_cast_family(&child.range.data_type(), target_type) {
- Ok(child.clone().with_range(unbounded))
+ let source_type = child.range.data_type();
+ // A widening cast is additionally one-to-one, so it is strictly
Review Comment:
You are right, unfortunately this moved from here (so no logic change has
been made):
https://github.com/apache/datafusion/blob/e271f65c9f8188cb6b1876da099646f396e34e00/datafusion/physical-expr/src/equivalence/properties/mod.rs#L215
##########
datafusion/ffi/src/expr/expr_properties.rs:
##########
@@ -54,6 +54,9 @@ impl TryFrom<FFI_ExprProperties> for ExprProperties {
sort_properties,
range,
preserves_lex_ordering: value.preserves_lex_ordering,
+ // Not carried over the FFI boundary (it would break the ABI);
+ // stay conservative.
+ strictly_order_preserving: false,
Review Comment:
Should I make breaking change in FFI (by adding the field) while I'm here to
avoid 2 breaking changes? I'm not really familiar with this module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
