adriangb commented on code in PR #23813: URL: https://github.com/apache/datafusion/pull/23813#discussion_r3639470028
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -9607,3 +9607,69 @@ SET datafusion.execution.target_partitions = 4; statement ok DROP TABLE hits_raw; + +# Nested aggregate function calls are rejected during planning +# issue: https://github.com/apache/datafusion/issues/23812 +statement ok +CREATE TABLE nested_agg_t AS VALUES (1, 10.0), (1, 20.0), (2, 30.0); + +statement error DataFusion error: Error during planning: Aggregate function calls cannot be nested: 'sum\(nested_agg_t\.column2\)' is nested inside 'sum\(sum\(nested_agg_t\.column2\)\)' +SELECT column1, sum(sum(column2)) FROM nested_agg_t GROUP BY column1; + +statement error DataFusion error: Error during planning: Aggregate function calls cannot be nested: 'count\(nested_agg_t\.column2\)' is nested inside 'sum\(count\(nested_agg_t\.column2\)\)' +SELECT column1, sum(count(column2)) FROM nested_agg_t GROUP BY column1; + +statement error DataFusion error: Error during planning: Aggregate function calls cannot be nested +SELECT sum(sum(column2)) FROM nested_agg_t; + +statement error DataFusion error: Error during planning: Aggregate function calls cannot be nested +SELECT column1 FROM nested_agg_t GROUP BY column1 HAVING sum(sum(column2)) > 0; + +statement error DataFusion error: Error during planning: Aggregate function calls cannot be nested +SELECT column1, sum(column2 + sum(column2)) FROM nested_agg_t GROUP BY column1; + +statement error DataFusion error: Error during planning: Aggregate function calls cannot be nested +SELECT sum(column2) FILTER (WHERE sum(column2) > 0) FROM nested_agg_t; + +statement error DataFusion error: Error during planning: Aggregate function calls cannot be nested +SELECT array_agg(column2 ORDER BY sum(column2)) FROM nested_agg_t; + +# A window function nested inside an aggregate is rejected as well +statement error DataFusion error: Error during planning: Aggregate function calls cannot contain window function calls +SELECT sum(sum(column2) OVER ()) FROM nested_agg_t; + +# ... as are nested window functions +statement error DataFusion error: Error during planning: Window function calls cannot be nested +SELECT sum(sum(column2) OVER ()) OVER () FROM nested_agg_t; + +statement error DataFusion error: Error during planning: Window function calls cannot be nested Review Comment: added this coverage in ecabe8a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
