YutaLin commented on PR #4951: URL: https://github.com/apache/datafusion-comet/pull/4951#issuecomment-5066142305
> Do we need to handle Literal `Time64(Nanosecond)` in the planner (`create_expr`)? > Maybe try a query with `ORDER BY time_col LIMIT 10` Hi @parthchandra, thanks for review! CometLiteral already serializes a non-null TimeType literal as LongVal, but create_expr only handled LongVal for Int64 and timestamps. I added the missing conversion to ScalarValue::Time64Nanosecond(Some(value)) and a focused Rust unit test. I also added more sql tests, please help me review again, appreicate! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
