pavan51 commented on code in PR #23827: URL: https://github.com/apache/datafusion/pull/23827#discussion_r3643899718
########## datafusion/functions-aggregate/benches/sliding_min_max.rs: ########## @@ -0,0 +1,232 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use criterion::{BenchmarkId, Criterion, Throughput, criterion_group, criterion_main}; +use datafusion_common::ScalarValue; +use rand::Rng; +use std::collections::VecDeque; + +// === Old Two-Stack Queue Implementation === +#[derive(Debug)] +pub struct TwoStackMax<T> { + push_stack: Vec<(T, T)>, + pop_stack: Vec<(T, T)>, +} Review Comment: Updated. The sliding_min_max.rs benchmark now only tests the production MovingMax implementation directly. To establish the performance delta, I ran this benchmark against both the main branch and this branch individually(results posted in the main discussion). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
