github-actions[bot] commented on PR #23827: URL: https://github.com/apache/datafusion/pull/23827#issuecomment-5071162595
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-functions-aggregate v54.1.0 (current) Built [ 39.796s] (current) Parsing datafusion-functions-aggregate v54.1.0 (current) Parsed [ 0.045s] (current) Building datafusion-functions-aggregate v54.1.0 (baseline) Built [ 30.645s] (baseline) Parsing datafusion-functions-aggregate v54.1.0 (baseline) Parsed [ 0.049s] (baseline) Checking datafusion-functions-aggregate v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.220s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure inherent_method_now_returns_unit: inherent method now returns unit --- Description: A publicly-visible method that used to return a value now returns `()`. impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/inherent_method_now_returns_unit.ron Failed in: datafusion_functions_aggregate::min_max::MovingMin::pop in /home/runner/work/datafusion/datafusion/datafusion/functions-aggregate/src/min_max.rs:814 datafusion_functions_aggregate::min_max::MovingMax::pop in /home/runner/work/datafusion/datafusion/datafusion/functions-aggregate/src/min_max.rs:915 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 72.045s] datafusion-functions-aggregate ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
