alamb commented on code in PR #11945:
URL: https://github.com/apache/datafusion/pull/11945#discussion_r1713520236
##########
datafusion/common/src/utils/mod.rs:
##########
@@ -683,6 +683,69 @@ pub fn transpose<T>(original: Vec<Vec<T>>) -> Vec<Vec<T>> {
}
}
+/// Computes the `skip` and `fetch` parameters of a single limit that would be
Review Comment:
It is nice to put this into `utils` 👍
##########
datafusion/physical-optimizer/src/output_requirements.rs:
##########
@@ -286,3 +286,5 @@ fn require_top_ordering_helper(
Ok((plan, false))
}
}
+
+// See tests in datafusion/core/tests/physical_optimizer
Review Comment:
❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
