andygrove commented on PR #4986:
URL:
https://github.com/apache/datafusion-comet/pull/4986#issuecomment-5093382331
> > Thanks @andygrove Athough we used `exec.shuffle` before, I checked spark
conf and they used just `spark.shuffle`.
> > However this is a super breaking change, people using Comet would have
to reconfigure their jobs. I'm not sure about migration path
>
> This is not a breaking changes. All the original configs are still
supported but deprecated.
Example from this PR:
```scala
val COMET_SHUFFLE_DIRECT_READ_ENABLED: ConfigEntry[Boolean] =
conf("spark.comet.shuffle.directRead.enabled")
.withAlternative(s"$COMET_EXEC_CONFIG_PREFIX.shuffle.directRead.enabled")
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
