mbutrovich commented on code in PR #4986:
URL: https://github.com/apache/datafusion-comet/pull/4986#discussion_r3666975577
##########
docs/source/contributor-guide/native_shuffle.md:
##########
@@ -244,14 +250,14 @@ independently compressed, allowing parallel decompression
during reads.
## Configuration
-| Config | Default | Description
|
-| ------------------------------------------------- | ------- |
---------------------------------------- |
-| `spark.comet.exec.shuffle.enabled` | `true` | Enable Comet
shuffle |
-| `spark.comet.exec.shuffle.mode` | `auto` | Shuffle mode:
`native`, `jvm`, or `auto` |
-| `spark.comet.exec.shuffle.compression.codec` | `zstd` | Compression
codec |
-| `spark.comet.exec.shuffle.compression.zstd.level` | `1` | Zstd
compression level |
-| `spark.comet.shuffle.write.buffer.size` | `1MB` | Write buffer
size |
-| `spark.comet.columnar.shuffle.batch.size` | `8192` | Target rows
per batch |
+| Config | Default | Description
|
+| -------------------------------------------- | ------- |
---------------------------------------- |
+| `spark.comet.shuffle.enabled` | `true` | Enable Comet
shuffle |
+| `spark.comet.shuffle.mode` | `auto` | Shuffle mode:
`native`, `jvm`, or `auto` |
+| `spark.comet.shuffle.compression.codec` | `zstd` | Compression codec
|
+| `spark.comet.shuffle.compression.zstd.level` | `1` | Zstd compression
level |
+| `spark.comet.shuffle.write.buffer.size` | `1MB` | Write buffer size
|
Review Comment:
the Configuration table's write-buffer-size row still shows
`spark.comet.shuffle.write.buffer.size`, which is not a valid config key (the
actual key was `spark.comet.exec.shuffle.writeBufferSize`, now
`spark.comet.shuffle.native.writeBufferSize`). Every other row in this same
table was correctly renamed by this PR; this one was missed. Update to
`spark.comet.shuffle.native.writeBufferSize`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
