Jefffrey commented on code in PR #23917:
URL: https://github.com/apache/datafusion/pull/23917#discussion_r3662026291
##########
datafusion/common/src/utils/hex.rs:
##########
@@ -72,6 +74,44 @@ impl HexCase {
}
}
+/// Trait for converting integer types to hexadecimal in a buffer
+pub trait ToHex: ArrowNativeType {
Review Comment:
i wonder if we should seal this; making it `pub` is unavoidable and
increases our api surface, but at least sealing it gives us more flexibility
should we ever need it 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
