SubhamSinghal commented on code in PR #23869:
URL: https://github.com/apache/datafusion/pull/23869#discussion_r3667294420
##########
datafusion/physical-optimizer/src/window_topn.rs:
##########
@@ -325,6 +336,7 @@ fn supported_window_fn(
match udf.fun().name() {
"row_number" => Some(WindowFnKind::RowNumber),
"rank" => Some(WindowFnKind::Rank),
+ "dense_rank" => Some(WindowFnKind::DenseRank),
Review Comment:
Fixed in 4530bba18ccbf135cf2b1ef85e37fd321cb946d7. The rewrite now bails
unless every window expr is ROW_NUMBER/RANK/DENSE_RANK over the same PARTITION
BY/ORDER BY. LEAD and aggregates are excluded. Added EXPLAIN + correctness SLT
regressions for SUM and LEAD siblings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
