2010YOUY01 commented on issue #22710: URL: https://github.com/apache/datafusion/issues/22710#issuecomment-5112961077
> I'm trying to simplify the code even further by writing with async generators, you can see the first PR here: > > * [chore(ordered-partial-aggregate): move `OrderedPartialAggregateStream` to generators for readability #23951](https://github.com/apache/datafusion/pull/23951) I think they make the implementation simpler if the state transitions are simple and linear, like in that PR's case `reading input -> producing output -> done` If the states transitions are more complex, the explicit state management is required IMO, I'm not sure if there are some way to simplify them similarly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
