andygrove commented on issue #3117: URL: https://github.com/apache/datafusion-comet/issues/3117#issuecomment-5113045212
`TryMakeTimestamp` is a `RuntimeReplaceable` expression. The `ReplaceExpressions` rule (Finish Analysis batch) substitutes it with its `replacement` before physical planning, so the class never appears in a physical plan and Comet's expression serde never sees it. Registering a `CometExpressionSerde` for it would be dead code. Its replacement is `MakeTimestamp(..., failOnError = false)`, and Comet already supports `MakeTimestamp` (`CometMakeTimestamp` in `QueryPlanSerde.scala`). So `try_make_timestamp` is not gated on a serde for this class. Closing as not actionable as specified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
