andygrove commented on issue #3137: URL: https://github.com/apache/datafusion-comet/issues/3137#issuecomment-5113046728
`TimeWindow` is `Unevaluable` and never reaches physical planning: the `TimeWindowing` analyzer rule (`ResolveTimeWindows.scala`) rewrites it into projections, `Expand`, and `Filter` over ordinary arithmetic. Comet's expression serde therefore never sees this class. Support for batch `window()` grouping was added in #4784 by supporting the expressions that rewrite actually produces (`PreciseTimestampConversion`), which is the correct level to work at. Closing as not actionable as specified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
