asolimando commented on code in PR #23936: URL: https://github.com/apache/datafusion/pull/23936#discussion_r3676669582
########## datafusion/physical-plan/src/filter.rs: ########## Review Comment: Thanks for the suggestion, and checking `cap_at_rows` function I realized that it's yet another place where the same logic applied here to row_count, could apply to null count, distinct counts and `total_byte_size` (all could be `Exact(0)` instead of `Inexact(0)` today). Expanding the current PR to cover that would require generalizing the title and description, happy to do it but I wanted to double check if you wouldn't prefer a follow-up PR for that. To make it easier to decide, I have pushed the two changes (stacked on this PR), here: - [exact zero when capping counts at the filtered row count](https://github.com/asolimando/datafusion/commit/75107ec8272f606e57efb486a8206405320d156f) - [exact zero byte size for a contradictory predicate](https://github.com/asolimando/datafusion/commit/1034a39ce16b5b03f4b008fa288b0f4cc084218c) Happy both ways, a follow-up PR or updating the present one! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
