lyne7-sc commented on code in PR #23930:
URL: https://github.com/apache/datafusion/pull/23930#discussion_r3683082578
##########
datafusion/functions/src/unicode/character_length.rs:
##########
@@ -59,11 +62,16 @@ impl Default for CharacterLengthFunc {
impl CharacterLengthFunc {
pub fn new() -> Self {
- use DataType::*;
Self {
- signature: Signature::uniform(
- 1,
- vec![Utf8, LargeUtf8, Utf8View],
Review Comment:
I’ve switched both `character_length` and `reverse` to Any to restore the
previous implicit coercions. One difference for `reverse` is that non-string
inputs are now coerced to Utf8View instead of Utf8.
Tightening the signatures in a followup sounds good, especially since there
may be other functions with similar issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
