avantgardnerio commented on code in PR #2196:
URL:
https://github.com/apache/datafusion-ballista/pull/2196#discussion_r3706611791
##########
ballista/scheduler/src/state/aqe/adapter.rs:
##########
@@ -105,7 +108,24 @@ impl BallistaAdapter {
)?,
};
- Ok(Transformed::yes(Arc::new(reader)))
+ let reader: Arc<dyn ExecutionPlan> = Arc::new(reader);
+ // Without a per-partition filter, straddling sub-parts from a
+ // range-repartitioned upstream would feed multiple downstream
+ // partitions and `FinalPartitioned` would split their partial
sums.
+ if let Some(routing) = exchange.range_repartition_routing() {
Review Comment:
Thanks for catching this. I will go with the "bail" option for now, but I
filed https://github.com/apache/datafusion-ballista/issues/2220 for once we
have a real rule using this (soon).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
