milenkovicm commented on PR #1891:
URL:
https://github.com/apache/datafusion-ballista/pull/1891#issuecomment-5170206813
apologies @phillipleblanc for slow review, i'll try to catch up
one question, current ballista implementation does have
```rust
JobState::job_state_events(&self) -> Result<JobStateEventStream>;
```
not its a bit of ceremony to subscribe to it.
would it make sense for `TaskManager` to expose
```rust
pub async fn job_state_events(&self) -> Result<JobStateEventStream> {
self.state.job_state_events().await
}
```
and then SchedulerServer to expose
```rust
pub async fn job_state_events(&self) -> Result<JobStateEventStream> {
self.state.task_manager.job_state_events().await
}
```
`JobStateEventStream` is defined as:
```rust
pub type JobStateEventStream = Pin<Box<dyn Stream<Item = JobStateEvent> +
Send>>;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
