2010YOUY01 commented on PR #24066: URL: https://github.com/apache/datafusion/pull/24066#issuecomment-5176545915
> I can do that - but I've tested out all these lints (and more) myself over the last couple of years in both https://github.com/rerun-io/rerun and https://github.com/emilk/egui and can vouch for their usefulness Splitting them into separate PRs can make them easier to review. I suggest to do the following steps 1. https://github.com/apache/datafusion/pull/24076 LGTM, I'll merge it shortly 2. Open a separate PR for commit [feat: enable a batch of non-default clippy lints workspace-wide](https://github.com/apache/datafusion/pull/24066/commits/5cc8f99704fb004c9b9018ae3c1e65bbae196e87) 3. I will review the extra lint rule list later (that list is really helpful!), if there is no issue, we could do that in another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
