divyankshah commented on PR #5235:
URL:
https://github.com/apache/datafusion-comet/pull/5235#issuecomment-5195038287
Hi @andygrove,
thanks for letting me know the -0.0 literal trap, good to know for future
fixtures too. addressed in the latest commit:
1) fixed arrays_overlap.sql:120 to use double('0.0')/double('-0.0') instead
of bare literals
2) added test_overlap_nested_dbl and test_overlap_struct_dbl to
arrays_overlap.sql
3) added test_ap_nested_dbl to array_position.sql, kept the trailing NULL
inner list row
4) added a comment on arrays_overlap_list_generic noting the flat path stays
untouched since Spark's flat and nested paths disagree on signed zero
5) added a comment on test_struct_float_field_signed_zero_position noting
it's not reachable from SQL yet
Please let me know if anything needs to be adjusted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
