oc7o commented on code in PR #23188:
URL: https://github.com/apache/datafusion/pull/23188#discussion_r3726162425
##########
datafusion/proto-models/proto/datafusion.proto:
##########
@@ -1050,6 +1050,8 @@ message PhysicalExprNode {
PhysicalHigherOrderUdfNode higher_order_udf = 24;
PhysicalLambdaExprNode lambda = 25;
PhysicalLambdaVariableExprNode lambda_variable = 26;
+
+ PhysicalSqlSimilarToPatternNode sql_similar_to_pattern = 27;
Review Comment:
@kosiew
Went with the versioning-strategy route: I added an entry to
docs/source/library-user-guide/upgrading/55.0.0.md documenting
ExprType::SqlSimilarToPattern as a breaking proto change for the upcoming
55.0.0 release
([diff](https://github.com/apache/datafusion/pull/23188/changes/2d2b4f9f9f9b9651a7fd903478cc3ceb5b727efd#diff-98fe34b7fd9941deed1f5ff0a91bd04175b513b5dd38134dd6adfd86f58408ad)).
This follows the same convention already used for other breaking proto/API
changes merged ahead of the version bump (e.g. the
EmptyExecNode/PlaceholderRowExecNode entry). The actual Cargo.toml bump happens
separately as part of the release process, not per-PR, so nothing else needed
here on my end.
Let me know if you'd rather I drop the proto support instead and keep it out
of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
