2010YOUY01 commented on code in PR #24066:
URL: https://github.com/apache/datafusion/pull/24066#discussion_r3727543413
##########
Cargo.toml:
##########
@@ -210,29 +210,110 @@ uuid = "1.23"
zstd = { version = "0.13", default-features = false }
# Keep this list sorted alphabetically.
+# See https://github.com/apache/datafusion/issues/18467 for the ongoing effort
of
+# picking useful non-default lints.
[workspace.lints.clippy]
# https://github.com/apache/datafusion/issues/18881
allow_attributes = "warn"
+as_ptr_cast_mut = "warn"
assigning_clones = "warn"
+char_lit_as_u8 = "warn"
+clear_with_drain = "warn"
+coerce_container_to_any = "warn"
+debug_assert_with_mut_call = "warn"
+decimal_bitwise_operands = "warn"
+default_union_representation = "warn"
+doc_include_without_cfg = "warn"
+empty_enum_variants_with_brackets = "warn"
+empty_line_after_outer_attr = "warn"
+exit = "warn"
+flat_map_option = "warn"
+fn_to_numeric_cast_any = "warn"
+if_let_mutex = "warn"
+imprecise_flops = "warn"
+index_refutable_slice = "warn"
inefficient_to_string = "warn"
+infinite_loop = "warn"
+invalid_upcast_comparisons = "warn"
+ip_constant = "warn"
+iter_filter_is_ok = "warn"
+iter_filter_is_some = "warn"
+iter_on_empty_collections = "warn"
# Detects large stack-allocated futures that may cause stack overflow crashes
(see threshold in clippy.toml)
large_futures = "warn"
+large_include_file = "warn"
+macro_use_imports = "warn"
+manual_ilog2 = "warn"
+manual_instant_elapsed = "warn"
+manual_is_power_of_two = "warn"
+manual_ok_or = "warn"
+match_wild_err_arm = "warn"
+mem_forget = "warn"
+mismatching_type_param_order = "warn"
+missing_enforced_import_renames = "warn"
+mut_mut = "warn"
+mutex_integer = "warn"
# https://github.com/apache/datafusion/issues/18503
needless_pass_by_value = "warn"
+negative_feature_names = "warn"
+non_zero_suggestions = "warn"
+nonstandard_macro_braces = "warn"
or_fun_call = "warn"
+path_buf_push_overwrite = "warn"
+pathbuf_init_then_push = "warn"
+precedence_bits = "warn"
+pub_underscore_fields = "warn"
+rc_mutex = "warn"
+ref_option_ref = "warn"
+same_length_and_capacity = "warn"
+str_split_at_newline = "warn"
+string_add_assign = "warn"
+suspicious_command_arg_space = "warn"
+suspicious_xor_used_as_pow = "warn"
+trailing_empty_array = "warn"
+transmute_ptr_to_ptr = "warn"
+uninhabited_references = "warn"
uninlined_format_args = "warn"
unnecessary_lazy_evaluations = "warn"
+unnecessary_safety_comment = "warn"
+unnecessary_self_imports = "warn"
unused_async = "warn"
+unused_rounding = "warn"
used_underscore_binding = "warn"
+useless_transmute = "warn"
+verbose_file_reads = "warn"
+wildcard_dependencies = "warn"
+zero_sized_map_values = "warn"
+# Keep this list sorted alphabetically.
[workspace.lints.rust]
Review Comment:
looks like this change is unrelated to this PR
##########
Cargo.toml:
##########
@@ -210,29 +210,110 @@ uuid = "1.23"
zstd = { version = "0.13", default-features = false }
# Keep this list sorted alphabetically.
+# See https://github.com/apache/datafusion/issues/18467 for the ongoing effort
of
+# picking useful non-default lints.
[workspace.lints.clippy]
# https://github.com/apache/datafusion/issues/18881
allow_attributes = "warn"
+as_ptr_cast_mut = "warn"
assigning_clones = "warn"
+char_lit_as_u8 = "warn"
+clear_with_drain = "warn"
+coerce_container_to_any = "warn"
+debug_assert_with_mut_call = "warn"
+decimal_bitwise_operands = "warn"
+default_union_representation = "warn"
+doc_include_without_cfg = "warn"
+empty_enum_variants_with_brackets = "warn"
+empty_line_after_outer_attr = "warn"
+exit = "warn"
+flat_map_option = "warn"
+fn_to_numeric_cast_any = "warn"
+if_let_mutex = "warn"
+imprecise_flops = "warn"
+index_refutable_slice = "warn"
inefficient_to_string = "warn"
+infinite_loop = "warn"
+invalid_upcast_comparisons = "warn"
+ip_constant = "warn"
+iter_filter_is_ok = "warn"
+iter_filter_is_some = "warn"
+iter_on_empty_collections = "warn"
# Detects large stack-allocated futures that may cause stack overflow crashes
(see threshold in clippy.toml)
large_futures = "warn"
+large_include_file = "warn"
+macro_use_imports = "warn"
+manual_ilog2 = "warn"
+manual_instant_elapsed = "warn"
+manual_is_power_of_two = "warn"
+manual_ok_or = "warn"
+match_wild_err_arm = "warn"
+mem_forget = "warn"
+mismatching_type_param_order = "warn"
+missing_enforced_import_renames = "warn"
+mut_mut = "warn"
+mutex_integer = "warn"
# https://github.com/apache/datafusion/issues/18503
needless_pass_by_value = "warn"
+negative_feature_names = "warn"
+non_zero_suggestions = "warn"
+nonstandard_macro_braces = "warn"
or_fun_call = "warn"
+path_buf_push_overwrite = "warn"
+pathbuf_init_then_push = "warn"
+precedence_bits = "warn"
+pub_underscore_fields = "warn"
+rc_mutex = "warn"
+ref_option_ref = "warn"
+same_length_and_capacity = "warn"
+str_split_at_newline = "warn"
+string_add_assign = "warn"
+suspicious_command_arg_space = "warn"
+suspicious_xor_used_as_pow = "warn"
+trailing_empty_array = "warn"
+transmute_ptr_to_ptr = "warn"
+uninhabited_references = "warn"
uninlined_format_args = "warn"
unnecessary_lazy_evaluations = "warn"
+unnecessary_safety_comment = "warn"
+unnecessary_self_imports = "warn"
unused_async = "warn"
+unused_rounding = "warn"
used_underscore_binding = "warn"
+useless_transmute = "warn"
+verbose_file_reads = "warn"
+wildcard_dependencies = "warn"
+zero_sized_map_values = "warn"
+# Keep this list sorted alphabetically.
[workspace.lints.rust]
+# Part of the `rust_2018_idioms` group, but ~800 violations today:
+# https://github.com/apache/datafusion/issues/18467
+elided_lifetimes_in_paths = "allow"
+future_incompatible = { level = "warn", priority = -1 }
+nonstandard_style = { level = "warn", priority = -1 }
+rust_2018_idioms = { level = "warn", priority = -1 }
+rust_2021_prelude_collisions = "warn"
+semicolon_in_expressions_from_macros = "warn"
unexpected_cfgs = { level = "warn", check-cfg = [
'cfg(datafusion_coop, values("tokio", "tokio_fallback", "per_stream"))',
"cfg(coverage)",
"cfg(coverage_nightly)",
] }
+unsafe_op_in_unsafe_fn = "warn"
+unused_extern_crates = "warn"
+unused_import_braces = "warn"
+unused_lifetimes = "warn"
unused_qualifications = "deny"
+# Keep this list sorted alphabetically.
+[workspace.lints.rustdoc]
Review Comment:
Looks like this is also unrelated.
##########
Cargo.toml:
##########
@@ -210,29 +210,110 @@ uuid = "1.23"
zstd = { version = "0.13", default-features = false }
# Keep this list sorted alphabetically.
+# See https://github.com/apache/datafusion/issues/18467 for the ongoing effort
of
+# picking useful non-default lints.
[workspace.lints.clippy]
Review Comment:
We're already rejecting default `warn` level categories in
https://doc.rust-lang.org/stable/clippy/index.html
So here are several rules we're already enforcing, and there is no need to
add explicitly. Later we only have to pick from categories outside
`correctness, suspicious, style, complexity, perf`
```
# Already included rules, no need to add
char_lit_as_u8, empty_line_after_outer_attr, if_let_mutex, manual_ok_or,
missing_enforced_import_renames, suspicious_command_arg_space, useless_transmute
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
