adriangb commented on code in PR #24165:
URL: https://github.com/apache/datafusion/pull/24165#discussion_r3737005015
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
Review Comment:
Should we use a builder the whole way through instead of a `try_new` and
then a builder later?
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -1959,6 +1960,16 @@ impl HashJoinExec {
hash_join = hash_join.with_dynamic_filter_expr(df)?;
}
+ // Restore the row limit that `limit_pushdown` may have pushed into the
+ // join. The field is presence-tracked, so a message written before it
+ // existed decodes to `None` (no limit) rather than to `Some(0)`.
+ if let Some(fetch) = hashjoin.fetch {
+ hash_join = hash_join
+ .builder()
Review Comment:
Let's avoid going from instance -> builder and back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
