andygrove commented on PR #2211: URL: https://github.com/apache/datafusion-ballista/pull/2211#issuecomment-5226665103
CI is red on two jobs here, but only one of them is yours. `cargo doc` is real: ``` error: public documentation for `FinalizedPartitionState` links to private item `self` error: public documentation for `PrefixMergeExec` links to private item `self` ``` The `[module-level docs][self]` links resolve to `mod prefix_merge`, which is private, so rustdoc rejects them under `-D warnings`. Making it `pub mod prefix_merge;` in `execution_plans/mod.rs` is the smallest fix and matches what `plan_algebra` and `sort_shuffle` already do. Dropping the two intra doc links works too if you'd rather keep the module private. `test linux crates` is not this PR. It's `ballista-chaos::ha exhausted_retries_fail_the_job_and_leave_the_cluster_healthy::case_1_aqe_off` failing at cluster startup with executor registration `ConnectionRefused`, so an infrastructure flake. Should clear on a rerun. Design feedback coming in a separate comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
