alamb commented on code in PR #24018: URL: https://github.com/apache/datafusion/pull/24018#discussion_r3748708956
########## datafusion/physical-plan/src/memory.rs: ########## Review Comment: > Good point. The behavior in this PR is inconsistent, so I just pushed a commit with a comment to define the behavior: I think we should ignore expressions in the properties() for several reasons I agree -- I think it is unlikely that expressions will appear in properties that do not also appear in other expressions of the node (e.g. the exprs in a ProjectionExec) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
