phillipleblanc commented on PR #2223: URL: https://github.com/apache/datafusion-ballista/pull/2223#issuecomment-5248888580
This makes sense as an improvement - I have one question about a potential wrong-answer issue: - For ascending order, `3 PRECEDING` means smaller numeric values, so widening the lower side of a range is correct. - For descending order, `3 PRECEDING` means larger numeric values. The PR still widens the lower side, so rows near a boundary may not receive all the values required for their window. I believe this means the query can succeed while returning incorrect results. We could initially restrict this optimization to ascending order, which will prevent the issue, but the correct fix would be to reverse the halo directions for descending order. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
