akshaychitneni opened a new issue, #2281:
URL: https://github.com/apache/datafusion-ballista/issues/2281
The scheduler decides whether to start its embedded Arrow Flight proxy by
matching on an empty string:
// ballista/scheduler/src/scheduler_process.rs:104
```
match &config.advertise_flight_sql_endpoint {
Some(proxy) if proxy.is_empty() => { /* start embedded flight proxy */
}
// Some("host:port") => advertise an external endpoint
// None => no proxy
}
```
So one Option<String> overloads three meanings, and Some("") = "enable the
embedded proxy" is non-obvious — a config/env value that happens to be empty
silently flips a mode.
Proposal: add an explicit enable_embedded_flight_proxy: bool (or an enum)
separate from the "advertise this external endpoint" string, and treat an empty
advertise_flight_sql_endpoint as
unset rather than as a switch.
Follow-up from [#2244
review](https://github.com/apache/datafusion-ballista/pull/2244#issuecomment-5226731477)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
