goutamadwant commented on PR #24179: URL: https://github.com/apache/datafusion/pull/24179#issuecomment-5262750830
> Thanks for this! High-level motivation and approach seems fine to me. > > I wonder whether `--spark` should also set the SQL dialect to "spark". Probably? Agreed and addressed it as well @neilconway `--spark` now also sets `datafusion.sql_parser.dialect` to `Dialect::Spark. I also updated the CLI help and user documentation to describe the full behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
