AdamGS commented on code in PR #24258: URL: https://github.com/apache/datafusion/pull/24258#discussion_r3765170399
########## datafusion/sqllogictest/test_files/predicates.slt: ########## @@ -976,14 +976,22 @@ create table t(x int) as values (1), (2), (3); query TT explain select x from t where x IN (1,2,3) AND x IN (4,5); ---- -logical_plan EmptyRelation: rows=0 -physical_plan EmptyExec +logical_plan +01)Filter: t.x IS NULL AND Boolean(NULL) +02)--TableScan: t projection=[x] +physical_plan +01)FilterExec: x@0 IS NULL AND NULL +02)--DataSourceExec: partitions=1, partition_sizes=[1] Review Comment: This seems like a regression? The current state optimizes this query away which is the optimal behavior here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
