zhuqi-lucas commented on PR #23696: URL: https://github.com/apache/datafusion/pull/23696#issuecomment-5267232917
Thanks @adriangb for the review and the good suggestions! Pushed the two correctness fixes in b31b0b4 — count the first-RG fully-matched suppression at open time, and error on decoder/plan divergence in `advance_rg_plan_to` instead of silently draining. Replies inline on the rest: factoring the initial-decoder setup into a named struct as a follow-up, and the `access_plan` strip is coupled to `fully_matched` for now (can extract the generic part later). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
