SubhamSinghal commented on PR #23870: URL: https://github.com/apache/datafusion/pull/23870#issuecomment-5268020612
@comphead - P1 — Classic Left/Full PiecewiseMergeJoin can silently drop unmatched rows pre-PR; the fix ships without a regression test -- Added UT in 2b73c41200016c9da23ae429e5849d28a3b7131f - P1 — Extreme-key extraction uses sort_to_indices(..., Some(1)) (O(N log N) full sort) instead of the O(N) MinAccumulator/MaxAccumulator pattern DataFusion already uses - fixed in 2b73c41200016c9da23ae429e5849d28a3b7131f - P2 — No benchmark despite "magnitudes faster" performance claim -- benchmark PR: https://github.com/apache/datafusion/pull/24160 - P2 — No fuzz coverage for PWMJ LeftSemi/LeftAnti in join_fuzz.rs -- added fuzz test in d3cec1334861894a69127190d13f9f9ffe26ce8c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
