milenkovicm opened a new issue, #2296: URL: https://github.com/apache/datafusion-ballista/issues/2296
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.** scheduler uses macro defined in https://github.com/apache/datafusion-ballista/blob/b6b6a21b78c7deed9a65b2ed7e535ff6aeea55df/ballista/scheduler/src/state/aqe/mod.rs#L1531 for all plan assertions in AQE submodule, https://github.com/apache/datafusion-ballista/blob/b6b6a21b78c7deed9a65b2ed7e535ff6aeea55df/ballista/scheduler/src/state/aqe/test/alter_stages.rs#L61 use of `insta::assert_snapshot!` crates a standardised way of plan assertions ad simplifies changes when/if plan changes. i would like to propose to move the macro to `core` module and use it as a standard way of plan assertion, in all tests **Describe the solution you'd like** - move macro to `core` module and use it for all plan assertions - consider creating `assert_batch` macro which would use `insta::assert_snapshot!` for batch assertions **Describe alternatives you've considered** **Additional context** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
