alamb commented on PR #24376: URL: https://github.com/apache/datafusion/pull/24376#issuecomment-5298201184
> That is a much narrower claim than the PR made. I still think Option<&[usize]> is the better signature on its own merits — it is what clippy::ptr_arg exists to discourage, and it lets the default scan_with_args body drop a Vec allocation and stop capturing it in the returned future I think it is ok too -- I was just trying to quantify eactly how much benefit there was for the API change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
