jordepic commented on PR #5361: URL: https://github.com/apache/datafusion-comet/pull/5361#issuecomment-5302953324
@andygrove all seven review comments are addressed — each thread above has a reply describing the change. The first full CI run also caught a real bug in my `fromCometPlan` rework (the session pre-check blanked native metrics on executors, failing `CometTaskMetricsSuite` on every [exec] shard); that's fixed in the current head, details on the metrics thread. Local verification on `810000baf`: - `CometIcebergWriteDetectionSuite` + `CometIcebergWriteActionSuite`: green on all four profiles (spark-3.4/scala-2.12, 3.5, 4.0, 4.1), including the new uuid-gate, fixed(N), and wide-primitive/non-UTC-timezone parity tests - `CometTaskMetricsSuite` (the CI failure): 6/6 on all four profiles - native `iceberg_write` unit tests 17/17; clippy, rustfmt, spotless, scalastyle, scalafix (spark-4.0), prettier, check-suites all clean Could you approve a CI run when you get a chance? One caveat from the last run: the macos-14 [scans] job died in a hotspot-level runner crash (`SIGTRAP` during error reporting, right after an unrelated timestamp suite) — same class of macos-14 flake as the [shuffle] one, so it may just need a re-run if it recurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
